[PATCH] D131398: [AMDGPU][MC][GFX11][NFC] Rename tests

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 07:29:40 PDT 2022


Joe_Nash added a reviewer: dstuttard.
Joe_Nash accepted this revision.
Joe_Nash added a comment.
This revision is now accepted and ready to land.

In D131398#3706536 <https://reviews.llvm.org/D131398#3706536>, @dp wrote:

> I agree, the suffices are redundant. I was reluctant to remove the `_asm/_dasm` suffices because they have been used for many pre-GFX11 tests.
> I can remove these suffices - for all targets or for GFX11 only. What do you think would be better?

The only reason I can think that the name would matter is if people scripted against the old names. If you don't want to rename the old ones you have to trade off between uniformity (include asm/dasm) and simplicity on GFX11.  I'm agnostic about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131398/new/

https://reviews.llvm.org/D131398



More information about the llvm-commits mailing list