[compiler-rt] af8205d - Revert "XFAIL some PGO tests on AIX until the new linker becomes publicly available."
Wael Yehia via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 8 07:05:16 PDT 2022
Author: Wael Yehia
Date: 2022-08-08T14:04:29Z
New Revision: af8205d0eb47b416b6865488056797f4162321e4
URL: https://github.com/llvm/llvm-project/commit/af8205d0eb47b416b6865488056797f4162321e4
DIFF: https://github.com/llvm/llvm-project/commit/af8205d0eb47b416b6865488056797f4162321e4.diff
LOG: Revert "XFAIL some PGO tests on AIX until the new linker becomes publicly available."
AIX 7.2 TL5 SP4 and AIX 7.3 TL0 SP2 have been released as of now.
The linker in these OS versions recognizes and properly supports
__start_SECNAME and __stop_SECNAME symbols which are needed for PGO.
This reverts commit 93bb2f16e85d2d4c8d3ddadebd99fc0fe26d974b.
Added:
Modified:
compiler-rt/test/profile/Posix/gcov-destructor.c
compiler-rt/test/profile/Posix/gcov-execlp.c
compiler-rt/test/profile/Posix/gcov-fork.c
compiler-rt/test/profile/Posix/instrprof-gcov-parallel.test
compiler-rt/test/profile/Posix/instrprof-get-filename-merge-mode.c
compiler-rt/test/profile/gcov-__gcov_flush-terminate.c
compiler-rt/test/profile/gcov-basic.c
compiler-rt/test/profile/gcov-complex-line.c
compiler-rt/test/profile/gcov-dump-and-remove.c
compiler-rt/test/profile/infinite_loop.c
compiler-rt/test/profile/instrprof-coverage.c
compiler-rt/test/profile/instrprof-gcov-exceptions.test
compiler-rt/test/profile/instrprof-gcov-multiple-bbs-single-line.test
compiler-rt/test/profile/instrprof-gcov-multithread_fork.test
compiler-rt/test/profile/instrprof-gcov-one-line-function.test
compiler-rt/test/profile/instrprof-gcov-switch.test
compiler-rt/test/profile/instrprof-gcov-two-objects.test
compiler-rt/test/profile/instrprof-get-filename.c
compiler-rt/test/profile/instrprof-icall-promo.test
compiler-rt/test/profile/instrprof-merge-entry-cover.c
compiler-rt/test/profile/instrprof-path.c
compiler-rt/test/profile/instrprof-set-dir-mode.c
compiler-rt/test/profile/runtime_infinite.c
Removed:
################################################################################
diff --git a/compiler-rt/test/profile/Posix/gcov-destructor.c b/compiler-rt/test/profile/Posix/gcov-destructor.c
index 8cd9712d236b0..c6fa144bcb39f 100644
--- a/compiler-rt/test/profile/Posix/gcov-destructor.c
+++ b/compiler-rt/test/profile/Posix/gcov-destructor.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
/// Test that destructors and destructors whose priorities are greater than 100 are tracked.
// RUN: mkdir -p %t.dir && cd %t.dir
// RUN: %clang --coverage %s -o %t
diff --git a/compiler-rt/test/profile/Posix/gcov-execlp.c b/compiler-rt/test/profile/Posix/gcov-execlp.c
index 805710ead3898..362f59516d217 100644
--- a/compiler-rt/test/profile/Posix/gcov-execlp.c
+++ b/compiler-rt/test/profile/Posix/gcov-execlp.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
/// A basic block with fork/exec* is split. .gcda is flushed immediately before
/// fork/exec* so the lines before exec* are counted once while succeeding
/// lines are not counted.
diff --git a/compiler-rt/test/profile/Posix/gcov-fork.c b/compiler-rt/test/profile/Posix/gcov-fork.c
index e389ac5de648b..e66690a961e2e 100644
--- a/compiler-rt/test/profile/Posix/gcov-fork.c
+++ b/compiler-rt/test/profile/Posix/gcov-fork.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
/// A basic block with fork/exec* is split. .gcda is flushed immediately before
/// fork/exec* so the lines before fork are counted once while succeeding
/// lines are counted twice.
diff --git a/compiler-rt/test/profile/Posix/instrprof-gcov-parallel.test b/compiler-rt/test/profile/Posix/instrprof-gcov-parallel.test
index dce21a1e1d61a..0c7198e3c4e9e 100644
--- a/compiler-rt/test/profile/Posix/instrprof-gcov-parallel.test
+++ b/compiler-rt/test/profile/Posix/instrprof-gcov-parallel.test
@@ -1,4 +1,3 @@
-XFAIL: aix
RUN: mkdir -p %t.d
RUN: cd %t.d
diff --git a/compiler-rt/test/profile/Posix/instrprof-get-filename-merge-mode.c b/compiler-rt/test/profile/Posix/instrprof-get-filename-merge-mode.c
index c01177be957d0..477adcd44e47d 100644
--- a/compiler-rt/test/profile/Posix/instrprof-get-filename-merge-mode.c
+++ b/compiler-rt/test/profile/Posix/instrprof-get-filename-merge-mode.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// Test __llvm_profile_get_filename when the on-line merging mode is enabled.
//
// RUN: echo get_filename_from_DSO > shr.exp
diff --git a/compiler-rt/test/profile/gcov-__gcov_flush-terminate.c b/compiler-rt/test/profile/gcov-__gcov_flush-terminate.c
index e96d5d01abb68..649538dc2aaf1 100644
--- a/compiler-rt/test/profile/gcov-__gcov_flush-terminate.c
+++ b/compiler-rt/test/profile/gcov-__gcov_flush-terminate.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
/// https://bugs.llvm.org/show_bug.cgi?id=38067
/// An abnormal exit does not clear execution counts of subsequent instructions.
// RUN: mkdir -p %t.dir && cd %t.dir
diff --git a/compiler-rt/test/profile/gcov-basic.c b/compiler-rt/test/profile/gcov-basic.c
index 81c44df95fe21..0d8be6d7de087 100644
--- a/compiler-rt/test/profile/gcov-basic.c
+++ b/compiler-rt/test/profile/gcov-basic.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// RUN: mkdir -p %t.dir && cd %t.dir
/// gcov 3.4 redesigned the format and changed the extension from .da to .gcda
diff --git a/compiler-rt/test/profile/gcov-complex-line.c b/compiler-rt/test/profile/gcov-complex-line.c
index 692b96db3019f..86286c4a93a58 100644
--- a/compiler-rt/test/profile/gcov-complex-line.c
+++ b/compiler-rt/test/profile/gcov-complex-line.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// This test checks that the cycle detection algorithm in llvm-cov is able to
// handle complex block graphs by skipping zero count cycles.
//
diff --git a/compiler-rt/test/profile/gcov-dump-and-remove.c b/compiler-rt/test/profile/gcov-dump-and-remove.c
index 396191528a582..c35640f93b3de 100644
--- a/compiler-rt/test/profile/gcov-dump-and-remove.c
+++ b/compiler-rt/test/profile/gcov-dump-and-remove.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
/// Test we close file handle on flush, so the .gcda file can be deleted on
/// Windows while the process is still running. In addition, test we create
/// a new .gcda on flush, so there is a file when the process exists.
diff --git a/compiler-rt/test/profile/infinite_loop.c b/compiler-rt/test/profile/infinite_loop.c
index 4178fe4cc0f38..0e3981c712f6b 100644
--- a/compiler-rt/test/profile/infinite_loop.c
+++ b/compiler-rt/test/profile/infinite_loop.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// RUN: %clang_pgogen -O2 -o %t %s
// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
// RUN: llvm-profdata show -function main -counts %t.profraw| FileCheck %s
diff --git a/compiler-rt/test/profile/instrprof-coverage.c b/compiler-rt/test/profile/instrprof-coverage.c
index 88b46985e1143..3f3cd18ef7600 100644
--- a/compiler-rt/test/profile/instrprof-coverage.c
+++ b/compiler-rt/test/profile/instrprof-coverage.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// RUN: %clang_pgogen -mllvm -pgo-function-entry-coverage %s -o %t.out
// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t.out
// RUN: llvm-profdata merge -o %t.profdata %t.profraw
diff --git a/compiler-rt/test/profile/instrprof-gcov-exceptions.test b/compiler-rt/test/profile/instrprof-gcov-exceptions.test
index f7910b2f75843..a3dcc55aaf5b6 100644
--- a/compiler-rt/test/profile/instrprof-gcov-exceptions.test
+++ b/compiler-rt/test/profile/instrprof-gcov-exceptions.test
@@ -1,4 +1,3 @@
-XFAIL: aix
RUN: mkdir -p %t.d
RUN: cd %t.d
diff --git a/compiler-rt/test/profile/instrprof-gcov-multiple-bbs-single-line.test b/compiler-rt/test/profile/instrprof-gcov-multiple-bbs-single-line.test
index cc1dc34cd2673..66b6429208a0f 100644
--- a/compiler-rt/test/profile/instrprof-gcov-multiple-bbs-single-line.test
+++ b/compiler-rt/test/profile/instrprof-gcov-multiple-bbs-single-line.test
@@ -1,4 +1,3 @@
-XFAIL: aix
RUN: mkdir -p %t.d
RUN: cd %t.d
diff --git a/compiler-rt/test/profile/instrprof-gcov-multithread_fork.test b/compiler-rt/test/profile/instrprof-gcov-multithread_fork.test
index e05ef2c6f11e5..f5ecb1e8dffe3 100644
--- a/compiler-rt/test/profile/instrprof-gcov-multithread_fork.test
+++ b/compiler-rt/test/profile/instrprof-gcov-multithread_fork.test
@@ -1,4 +1,3 @@
-XFAIL: aix
UNSUPPORTED: windows
RUN: mkdir -p %t.d
diff --git a/compiler-rt/test/profile/instrprof-gcov-one-line-function.test b/compiler-rt/test/profile/instrprof-gcov-one-line-function.test
index bb1c1653cfee1..d67c21a863bfc 100644
--- a/compiler-rt/test/profile/instrprof-gcov-one-line-function.test
+++ b/compiler-rt/test/profile/instrprof-gcov-one-line-function.test
@@ -1,4 +1,3 @@
-XFAIL: aix
RUN: mkdir -p %t.d
RUN: cd %t.d
diff --git a/compiler-rt/test/profile/instrprof-gcov-switch.test b/compiler-rt/test/profile/instrprof-gcov-switch.test
index 1616cf0d10f86..9c43a93dc646a 100644
--- a/compiler-rt/test/profile/instrprof-gcov-switch.test
+++ b/compiler-rt/test/profile/instrprof-gcov-switch.test
@@ -1,4 +1,3 @@
-XFAIL: aix
RUN: mkdir -p %t.d
RUN: cd %t.d
diff --git a/compiler-rt/test/profile/instrprof-gcov-two-objects.test b/compiler-rt/test/profile/instrprof-gcov-two-objects.test
index 2a7805ed998a8..4080caa7fdd9a 100644
--- a/compiler-rt/test/profile/instrprof-gcov-two-objects.test
+++ b/compiler-rt/test/profile/instrprof-gcov-two-objects.test
@@ -1,4 +1,3 @@
-XFAIL: aix
RUN: mkdir -p %t.d
RUN: cd %t.d
diff --git a/compiler-rt/test/profile/instrprof-get-filename.c b/compiler-rt/test/profile/instrprof-get-filename.c
index c6cec8cc3273e..031b75f12f3c2 100644
--- a/compiler-rt/test/profile/instrprof-get-filename.c
+++ b/compiler-rt/test/profile/instrprof-get-filename.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// Test __llvm_profile_get_filename.
// RUN: %clang_pgogen -O2 -o %t %s
// RUN: %run %t
diff --git a/compiler-rt/test/profile/instrprof-icall-promo.test b/compiler-rt/test/profile/instrprof-icall-promo.test
index 53a7817d37e2e..2519b5cd119ce 100644
--- a/compiler-rt/test/profile/instrprof-icall-promo.test
+++ b/compiler-rt/test/profile/instrprof-icall-promo.test
@@ -1,4 +1,3 @@
-// XFAIL: aix
# IR based instrumentation
RUN: %clangxx_pgogen -O2 -c -o %t.1.o %S/Inputs/instrprof-icall-promo_1.cpp
RUN: %clangxx_pgogen -O2 -c -o %t.2.o %S/Inputs/instrprof-icall-promo_2.cpp
diff --git a/compiler-rt/test/profile/instrprof-merge-entry-cover.c b/compiler-rt/test/profile/instrprof-merge-entry-cover.c
index ea2a773891182..e8800d9b6ad28 100644
--- a/compiler-rt/test/profile/instrprof-merge-entry-cover.c
+++ b/compiler-rt/test/profile/instrprof-merge-entry-cover.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// RUN: %clang_pgogen -O2 -mllvm -pgo-function-entry-coverage -o %t %s
// RUN: %run %t %t.profraw 1 1
// RUN: llvm-profdata show --all-functions --counts %t.profraw | FileCheck %s
diff --git a/compiler-rt/test/profile/instrprof-path.c b/compiler-rt/test/profile/instrprof-path.c
index f54a898b12941..e4dc8961212c1 100644
--- a/compiler-rt/test/profile/instrprof-path.c
+++ b/compiler-rt/test/profile/instrprof-path.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// RUN: %clang_pgogen -O2 -o %t.0 %s
// RUN: %clang_pgogen=%/t.d1 -O2 -o %t.1 %s
// RUN: %clang_pgogen=%/t.d1/%:t.d2 -O2 -o %t.2 %s
diff --git a/compiler-rt/test/profile/instrprof-set-dir-mode.c b/compiler-rt/test/profile/instrprof-set-dir-mode.c
index bc91bce4c030b..07c714724b883 100644
--- a/compiler-rt/test/profile/instrprof-set-dir-mode.c
+++ b/compiler-rt/test/profile/instrprof-set-dir-mode.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// UNSUPPORTED: windows
// RUN: %clang_pgogen -o %t.bin %s -DTESTPATH=\"%t.dir\"
// RUN: rm -rf %t.dir
diff --git a/compiler-rt/test/profile/runtime_infinite.c b/compiler-rt/test/profile/runtime_infinite.c
index adae991304e36..b55f5e2750dd9 100644
--- a/compiler-rt/test/profile/runtime_infinite.c
+++ b/compiler-rt/test/profile/runtime_infinite.c
@@ -1,4 +1,3 @@
-// XFAIL: aix
// The waiting loop never exits via the normal
// path before the profile is dumped and the
// program is terminated. This tests checks
More information about the llvm-commits
mailing list