[PATCH] D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V

[Alexey Baturo via Phabricator via llvm-commits]

smd added inline comments.


================
Comment at: compiler-rt/lib/hwasan/CMakeLists.txt:20
   hwasan_setjmp_x86_64.S
+  hwasan_setjmp_riscv64.S
   hwasan_tag_mismatch_aarch64.S
----------------
craig.topper wrote:
> this should be alphabetized above x86_64
Fixed, thanks


================
Comment at: compiler-rt/lib/hwasan/hwasan_setjmp_riscv64.S:62
+#ifndef __riscv_float_abi_soft
+  fsd   fs0,  14<<3(x10)
+  fsd   fs1,  15<<3(x10)
----------------
kito-cheng wrote:
> That might not work correctly for rv64if / lp64f, but that is rare combination, so I would suggest you add some `#if`/`#error` here to make sure that won't happen :)
Addressed this issue, thanks


================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn:72
     "hwasan_setjmp_x86_64.S",
+    "hwasan_setjmp_riscv64.S",
     "hwasan_tag_mismatch_aarch64.S",
----------------
craig.topper wrote:
> alphabetize
Fixed, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131341/new/

https://reviews.llvm.org/D131341