[PATCH] D131367: [CMake] Check CMAKE_CXX_STANDARD and error if it's to old

[Tobias Hieta via Phabricator via llvm-commits]

thieta added inline comments.


================
Comment at: llvm/CMakeLists.txt:68
+  message(WARNING "Resetting cache value for CMAKE_CXX_STANDARD to ${LLVM_REQUIRED_CXX_STANDARD}")
+  unset(CMAKE_CXX_STANDARD CACHE)
+endif()
----------------
barannikov88 wrote:
> This resets the cache variable in the main project, but what about subprojects? Will they also be affected?
> 
It should be reset for every other subproject that's included with ENABLE_PROJECTS - but with runtimes I am not sure what makes it re-gen the cache there which will be needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131367/new/

https://reviews.llvm.org/D131367