[PATCH] D130689: [LLVM] Update C++ standard to 17

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D130689#3706199 <https://reviews.llvm.org/D130689#3706199>, @cor3ntin wrote:

> Trying to read the logs,, notably `C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe `, it would seem that this particular bot is running a version much older than the current requirements  (Visual Studio 2019 16.7)
> Either I'm reading that wrong or the CMake script does not check the msvc version?

The compilers are definitely version checked here: https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/CheckCompilerVersion.cmake#L50

But reading the cmake log it seems like it's using a cache already and it's hard to say if it's using the same version of MSVC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130689/new/

https://reviews.llvm.org/D130689