[PATCH] D131355: [lld/mac] Use C++17 structured bindings
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 8 04:21:53 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb99da9d255e9: [lld/mac] Use C++17 structured bindings (authored by thakis).
Herald added a project: LLVM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131355/new/
https://reviews.llvm.org/D131355
Files:
lld/MachO/MapFile.cpp
lld/MachO/SymbolTable.cpp
Index: lld/MachO/SymbolTable.cpp
===================================================================
--- lld/MachO/SymbolTable.cpp
+++ lld/MachO/SymbolTable.cpp
@@ -51,10 +51,8 @@
bool isPrivateExtern, bool isThumb,
bool isReferencedDynamically, bool noDeadStrip,
bool isWeakDefCanBeHidden) {
- Symbol *s;
- bool wasInserted;
bool overridesWeakDef = false;
- std::tie(s, wasInserted) = insert(name, file);
+ auto [s, wasInserted] = insert(name, file);
assert(!isWeakDef || (isa<BitcodeFile>(file) && !isec) ||
(isa<ObjFile>(file) && file == isec->getFile()));
@@ -126,9 +124,7 @@
Symbol *SymbolTable::addUndefined(StringRef name, InputFile *file,
bool isWeakRef) {
- Symbol *s;
- bool wasInserted;
- std::tie(s, wasInserted) = insert(name, file);
+ auto [s, wasInserted] = insert(name, file);
RefState refState = isWeakRef ? RefState::Weak : RefState::Strong;
@@ -147,9 +143,7 @@
Symbol *SymbolTable::addCommon(StringRef name, InputFile *file, uint64_t size,
uint32_t align, bool isPrivateExtern) {
- Symbol *s;
- bool wasInserted;
- std::tie(s, wasInserted) = insert(name, file);
+ auto [s, wasInserted] = insert(name, file);
if (!wasInserted) {
if (auto *common = dyn_cast<CommonSymbol>(s)) {
@@ -168,9 +162,7 @@
Symbol *SymbolTable::addDylib(StringRef name, DylibFile *file, bool isWeakDef,
bool isTlv) {
- Symbol *s;
- bool wasInserted;
- std::tie(s, wasInserted) = insert(name, file);
+ auto [s, wasInserted] = insert(name, file);
RefState refState = RefState::Unreferenced;
if (!wasInserted) {
@@ -203,9 +195,7 @@
Symbol *SymbolTable::addLazyArchive(StringRef name, ArchiveFile *file,
const object::Archive::Symbol &sym) {
- Symbol *s;
- bool wasInserted;
- std::tie(s, wasInserted) = insert(name, file);
+ auto [s, wasInserted] = insert(name, file);
if (wasInserted) {
replaceSymbol<LazyArchive>(s, file, sym);
@@ -223,9 +213,7 @@
}
Symbol *SymbolTable::addLazyObject(StringRef name, InputFile &file) {
- Symbol *s;
- bool wasInserted;
- std::tie(s, wasInserted) = insert(name, &file);
+ auto [s, wasInserted] = insert(name, &file);
if (wasInserted) {
replaceSymbol<LazyObject>(s, file, name);
Index: lld/MachO/MapFile.cpp
===================================================================
--- lld/MachO/MapFile.cpp
+++ lld/MachO/MapFile.cpp
@@ -152,8 +152,7 @@
}
// Dump table of symbols
- Symbols liveSymbols, deadSymbols;
- std::tie(liveSymbols, deadSymbols) = getSymbols();
+ auto [liveSymbols, deadSymbols] = getSymbols();
DenseMap<Symbol *, std::string> liveSymbolStrings =
getSymbolStrings(liveSymbols);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131355.450764.patch
Type: text/x-patch
Size: 2884 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220808/d853ebdc/attachment.bin>
More information about the llvm-commits
mailing list