[llvm] fb10bb0 - ProcessTest.cpp - replace Optional::hasValue() with Optional::has_value()

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 03:52:39 PDT 2022


Author: Simon Pilgrim
Date: 2022-08-08T11:52:22+01:00
New Revision: fb10bb0d2c50d1ec2f3cf827d09f18bc54a8097a

URL: https://github.com/llvm/llvm-project/commit/fb10bb0d2c50d1ec2f3cf827d09f18bc54a8097a
DIFF: https://github.com/llvm/llvm-project/commit/fb10bb0d2c50d1ec2f3cf827d09f18bc54a8097a.diff

LOG: ProcessTest.cpp - replace Optional::hasValue() with Optional::has_value()

Fixes windows-only build warnings

Added: 
    

Modified: 
    llvm/unittests/Support/ProcessTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Support/ProcessTest.cpp b/llvm/unittests/Support/ProcessTest.cpp
index 4cf6ae87d8693..3169edb854757 100644
--- a/llvm/unittests/Support/ProcessTest.cpp
+++ b/llvm/unittests/Support/ProcessTest.cpp
@@ -46,14 +46,14 @@ TEST(ProcessTest, GetRandomNumberTest) {
 TEST(ProcessTest, Basic) {
   setenv("__LLVM_TEST_ENVIRON_VAR__", "abc", true);
   Optional<std::string> val(Process::GetEnv("__LLVM_TEST_ENVIRON_VAR__"));
-  EXPECT_TRUE(val.hasValue());
+  EXPECT_TRUE(val.has_value());
   EXPECT_STREQ("abc", val->c_str());
 }
 
 TEST(ProcessTest, None) {
   Optional<std::string> val(
       Process::GetEnv("__LLVM_TEST_ENVIRON_NO_SUCH_VAR__"));
-  EXPECT_FALSE(val.hasValue());
+  EXPECT_FALSE(val.has_value());
 }
 #endif
 
@@ -62,14 +62,14 @@ TEST(ProcessTest, None) {
 TEST(ProcessTest, EmptyVal) {
   SetEnvironmentVariableA("__LLVM_TEST_ENVIRON_VAR__", "");
   Optional<std::string> val(Process::GetEnv("__LLVM_TEST_ENVIRON_VAR__"));
-  EXPECT_TRUE(val.hasValue());
+  EXPECT_TRUE(val.has_value());
   EXPECT_STREQ("", val->c_str());
 }
 
 TEST(ProcessTest, Wchar) {
   SetEnvironmentVariableW(L"__LLVM_TEST_ENVIRON_VAR__", L"abcdefghijklmnopqrs");
   Optional<std::string> val(Process::GetEnv("__LLVM_TEST_ENVIRON_VAR__"));
-  EXPECT_TRUE(val.hasValue());
+  EXPECT_TRUE(val.has_value());
   EXPECT_STREQ("abcdefghijklmnopqrs", val->c_str());
 }
 #endif


        


More information about the llvm-commits mailing list