[PATCH] D130981: [yaml2obj] Add a `-E` flag to preprocess only.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/preprocess-only.test:3-7
+This is a test of yaml2obj's pure preprocessing mode, so it doesn't
+have to contain valid YAML, or any YAML at all. But we do have to be
+careful with the FileCheck CHECK directives, because they'll be
+emitted into the preprocessed output, and risk matching themselves!
+For that reason, each one matches only at the start of a line.
----------------
Probably not worth changing the test now that it's written (although I won't object if you choose to change things), but I think you could have avoided this by having the "YAML" in a separate file to the test in this case right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130981/new/

https://reviews.llvm.org/D130981