[PATCH] D131380: [LoongArch] Support register-register-addressed GPR loads/stores

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 02:33:17 PDT 2022


xen0n added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/ir-instruction/load-store.ll:464
 
+define void @stx_b(ptr %dst, i8 %idx, i8 %val) nounwind {
+; LA32-LABEL: stx_b:
----------------
SixWeining wrote:
> For load, you use `i64` no matter what the type of `%val` is . Here you use the same type as `%val`. Is this intented?
Oh well. I wrote the i64 version first, then copied and substituted types for the rest (including this one), apparently *this* i64 got replaced as well. Thanks for spotting this inconsistency, I'll fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131380/new/

https://reviews.llvm.org/D131380



More information about the llvm-commits mailing list