[PATCH] D131250: [scudo] Try to fix standalone build on armv7

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 01:22:11 PDT 2022


rovka added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/CMakeLists.txt:138-141
 set(SCUDO_LINK_LIBS)
 
+append_list_if(COMPILER_RT_USE_LLVM_UNWINDER ${COMPILER_RT_UNWINDER_LINK_LIBS}
+               SCUDO_LINK_LIBS)
----------------
phosek wrote:
> You should be able to set this unconditionally since `COMPILER_RT_UNWINDER_LINK_LIBS` is already set (or unset) based on the content of `COMPILER_RT_USE_LLVM_UNWINDER` (in the future it might also expand to `-lgcc` on other platforms).
Makes sense, thanks for the quick review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131250/new/

https://reviews.llvm.org/D131250



More information about the llvm-commits mailing list