[PATCH] D131257: [docs][AArch64] Label Features with Arm ARM Names

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM. Looks like a useful addition. D127812 <https://reviews.llvm.org/D127812> has need of some of these same FEAT_ names.



================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:35
   AEK_CRYPTO =      1 << 2,
   AEK_FP =          1 << 3,
   AEK_SIMD =        1 << 4,
----------------
The reference I have mentions FEAT_FP and FEAT_AdvSIMD.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:322
     "mpam", "HasMPAM", "true",
     "Enable v8.4-A Memory system Partitioning and Monitoring extension">;
 
----------------
Should this be FEAT_MPAM?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131257/new/

https://reviews.llvm.org/D131257