[PATCH] D131343: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V

Alexey Baturo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 7 23:10:58 PDT 2022


smd added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:264
+  assert(TT.isOSBinFormatELF());
+  std::unique_ptr<MCSubtargetInfo> STI(
+      TM.getTarget().createMCSubtargetInfo(TT.str(), "", ""));
----------------
craig.topper wrote:
> Why do we need to create STI when there's already an STI as a member of this class?
Fixed, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131343/new/

https://reviews.llvm.org/D131343



More information about the llvm-commits mailing list