[PATCH] D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 7 19:27:29 PDT 2022


kito-cheng added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_setjmp_riscv64.S:62
+#ifndef __riscv_float_abi_soft
+  fsd   fs0,  14<<3(x10)
+  fsd   fs1,  15<<3(x10)
----------------
That might not work correctly for rv64if / lp64f, but that is rare combination, so I would suggest you add some `#if`/`#error` here to make sure that won't happen :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131341/new/

https://reviews.llvm.org/D131341



More information about the llvm-commits mailing list