[PATCH] D127840: [MachinePipeliner] Fix Phi generation failure for large stages
Yuta Mukai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 7 19:12:31 PDT 2022
ytmukai marked an inline comment as done.
ytmukai added a comment.
@bcahoon Thanks for the review. I resolved the test case comment.
================
Comment at: llvm/test/CodeGen/PowerPC/sms-large-stages.mir:126
+ ; CHECK-NEXT: {{ $}}
+ ; CHECK-NEXT: %29:f4rc = nofpexcept XSADDSP [[LFSU]], %21
+ ; CHECK-NEXT: %30:vssrc = nofpexcept XSADDSP [[LFSU4]], [[LFSU4]]
----------------
rovka wrote:
> I'm noticing a mix of FileCheck variables (e.g. LFSU) and plain MIR numbered variables (e.g. %29). Is this how the script generated the checks? In general, I think it's preferred to replace numbered variables with either FileCheck variables if they're relevant for the test, or `{{.*}}` otherwise.
Sorry, I forgot to check for done. I fixed the test case to use FileCheck variables. update_mir_test_checks.py didn't replace MIR numbered variables because it doesn't recognize the instructions with the flag `nofpexcept`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127840/new/
https://reviews.llvm.org/D127840
More information about the llvm-commits
mailing list