[PATCH] D125444: [M68k] Add MC support for link/unlk
Sheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 7 19:01:38 PDT 2022
0x59616e added a comment.
In D125444#3689732 <https://reviews.llvm.org/D125444#3689732>, @myhsu wrote:
> LGTM
> Thank you! I only have some minor comments.
>
> In D125444#3659427 <https://reviews.llvm.org/D125444#3659427>, @0x59616e wrote:
>
>> Something worth noting about:
>>
>> - I guess the ".cfi_*" stuff may be wrong. Not sure about it.
>> - The assembly in link-unlink.ll, other than link/unlink itself, seems to be wrong. Bugs may exist somewhere.
>
> Yeah we can fix those later.
I'll open a issue citing this problem.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125444/new/
https://reviews.llvm.org/D125444
More information about the llvm-commits
mailing list