[PATCH] D131329: [SDAG] Add `getCALLSEQ_END` overload taking `uint64_t`s

[Roman Rusyaev via Phabricator via llvm-commits]

rusyaev-roman accepted this revision.
rusyaev-roman added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:955
   /// CALLSEQ_END does not have a useful SDLoc.
   SDValue getCALLSEQ_END(SDValue Chain, SDValue Op1, SDValue Op2,
                          SDValue InGlue, const SDLoc &DL) {
----------------
barannikov88 wrote:
> This method has become unused (except for in the overload below), but I'm hesitant to remove it.
> On one hand, removing it will force out-of-tree targets to adapt the new overload, on the other it should not be hard.
> These nodes already require their operands to be constants, only the value type may vary, but it does not look like a problem -- this may only require a slight modification of patterns.
> 
>From my point of view it's better to preserve this function to provide additional customization in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131329/new/

https://reviews.llvm.org/D131329