[PATCH] D131313: [Support] Use constexpr if

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 7 07:26:07 PDT 2022


thakis added a comment.

In D131313#3704232 <https://reviews.llvm.org/D131313#3704232>, @nikic wrote:

> I don't think we should use `if constexpr` if we don't actually require it's semantics. A normal `if` will get optimized just fine. The only actual change here is that the llvm_is_multithreaded() definition gets moved into the header, which allows this to optimize without LTO.

I agree with this, FWIW.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131313/new/

https://reviews.llvm.org/D131313



More information about the llvm-commits mailing list