[PATCH] D130613: Added warning about outdated feature into Kaleidoscope tutorial text

[Shivam Gupta via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfdc950958ed0: Added warning about outdated feature into Kaleidoscope tutorial text (authored by xgupta).

Changed prior to commit:
  https://reviews.llvm.org/D130613?vs=447924&id=450603#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130613/new/

https://reviews.llvm.org/D130613

Files:
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl04.rst


Index: llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl04.rst
===================================================================
--- llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl04.rst
+++ llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl04.rst
@@ -522,6 +522,11 @@
 the JIT and open a new module. In HandleExtern, we just need to add one line to
 add the prototype to FunctionProtos.
 
+.. warning::
+    Duplication of symbols in separate modules is not allowed since LLVM-9. That means you can not redefine function in your Kaleidoscope as its shown below. Just skip this part.
+
+    The reason is that the newer OrcV2 JIT APIs are trying to stay very close to the static and dynamic linker rules, including rejecting duplicate symbols. Requiring symbol names to be unique allows us to support concurrent compilation for symbols using the (unique) symbol names as keys for tracking.
+
 With these changes made, let's try our REPL again (I removed the dump of the
 anonymous functions this time, you should get the idea by now :) :
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130613.450603.patch
Type: text/x-patch
Size: 1049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220807/64f06b42/attachment.bin>