[PATCH] D131329: [SDAG] Add `getCALLSEQ_END` overload taking `uint64_t`s

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 6 10:28:41 PDT 2022


barannikov88 added reviewers: craig.topper, spatel, MaskRay.
barannikov88 added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:955
   /// CALLSEQ_END does not have a useful SDLoc.
   SDValue getCALLSEQ_END(SDValue Chain, SDValue Op1, SDValue Op2,
                          SDValue InGlue, const SDLoc &DL) {
----------------
This method has become unused (except for in the overload below), but I'm hesitant to remove it.
On one hand, removing it will force out-of-tree targets to adapt the new overload, on the other it should not be hard.
These nodes already require their operands to be constants, only the value type may vary, but it does not look like a problem -- this may only require a slight modification of patterns.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131329/new/

https://reviews.llvm.org/D131329



More information about the llvm-commits mailing list