[PATCH] D131158: [SystemZ] Improve handling of vector alignments

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 450537.
jonpa marked 2 inline comments as done.
jonpa added a comment.

Patch updated.

> This is already good news. However, I believe SPEC doesn't really use any attribute((vector_size)) so that might not tell us much. Can you do the same exercise with e.g. the llvm-test-suite? That does at least have a few instances of those types. It might also be good to run the ABI compat test suite (out of the GCC test suite).

I am quite sure that the llvm test-suite should pass with this patch (I rebuilt all files containing the attribute((vector_size)) and found no diff. For some reason I first got into trouble by merely adding -save-temps: undefined references at the link stage).

I tried running the GCC test suite as well, but sofar I have not been able to run it properly, I think (gcc failed the api check against itself).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131158/new/

https://reviews.llvm.org/D131158

Files:
  clang/lib/Basic/Targets/SystemZ.h
  clang/test/CodeGen/SystemZ/align-systemz-02.c
  clang/test/CodeGen/target-data.c
  llvm/lib/Target/SystemZ/SystemZTargetMachine.cpp
  llvm/test/CodeGen/SystemZ/function-attributes-01.ll
  llvm/test/CodeGen/SystemZ/vec-abi-align.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131158.450537.patch
Type: text/x-patch
Size: 13682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220806/2c6f6973/attachment.bin>