[PATCH] D131276: AMDGPU: Implicit kernel arguments related optimization when uniform-workgroup-size=true

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 23:50:13 PDT 2022


cfang marked an inline comment as done.
cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp:79
 
+static bool processImplicitArgUse(CallInst *CI) {
+  Function *F = CI->getParent()->getParent();
----------------
arsenm wrote:
> You've repeated most of the body of the existing function when only the core piece of the match differs.
Actually that is not pure repeat even though the logic is the same. The fields, offsets and even the base pointers are different. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131276/new/

https://reviews.llvm.org/D131276



More information about the llvm-commits mailing list