[PATCH] D131276: AMDGPU: Implicit kernel arguments related optimization when uniform-workgroup-size=true

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 14:37:38 PDT 2022


cfang added a comment.

In D131276#3703034 <https://reviews.llvm.org/D131276#3703034>, @b-sumner wrote:

> In D131276#3702934 <https://reviews.llvm.org/D131276#3702934>, @arsenm wrote:
>
>> I also think we're still missing a module flag to indicate the code object version
>
> The module flag was implemented quite a while back.   See D119026 <https://reviews.llvm.org/D119026> from February.  From a recent compile:
>
> !llvm.module.flags = !{!0, !1, !2}
> !0 = !{i32 1, !"amdgpu_code_object_version", i32 500}

We were using --amdhsa-code-object-version=5 to run LIT tests. Do you mean this flag will no longer take effect if we
switch to module flag for code object version?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131276/new/

https://reviews.llvm.org/D131276



More information about the llvm-commits mailing list