[compiler-rt] 29ff262 - [HWASan] Remove incorrect unreachable.

Florian Mayer via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 13:14:22 PDT 2022


Author: Florian Mayer
Date: 2022-08-05T13:14:08-07:00
New Revision: 29ff262761aff2e45cfa11659f677de83a830017

URL: https://github.com/llvm/llvm-project/commit/29ff262761aff2e45cfa11659f677de83a830017
DIFF: https://github.com/llvm/llvm-project/commit/29ff262761aff2e45cfa11659f677de83a830017.diff

LOG: [HWASan] Remove incorrect unreachable.

This function could be called wih access_info & 0x20 or with
flags()->halt_on_error, in which case HandleTagMismatch returns (is not
fatal).

Reviewed By: eugenis

Differential Revision: https://reviews.llvm.org/D131279

Added: 
    

Modified: 
    compiler-rt/lib/hwasan/hwasan.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/hwasan/hwasan.cpp b/compiler-rt/lib/hwasan/hwasan.cpp
index b771025cb93d3..352e4c8ce1241 100644
--- a/compiler-rt/lib/hwasan/hwasan.cpp
+++ b/compiler-rt/lib/hwasan/hwasan.cpp
@@ -232,7 +232,6 @@ void HwasanTagMismatch(uptr addr, uptr access_info, uptr *registers_frame,
 
   HandleTagMismatch(ai, (uptr)__builtin_return_address(0),
                     (uptr)__builtin_frame_address(0), nullptr, registers_frame);
-  __builtin_unreachable();
 }
 
 Thread *GetCurrentThread() {


        


More information about the llvm-commits mailing list