[PATCH] D123693: Transform illegal intrinsics to V_ILLEGAL

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM except for the stray debug print. We also  probably should clean up the the encoding to rely on subtarget features instead of the generation check



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:8396
+SDValue SITargetLowering::makeV_ILLEGAL(SDValue Op, SelectionDAG & DAG) const {
+  LLVM_DEBUG(dbgs() << "Subtarget->getGeneration() == " << Subtarget->getGeneration() << "\n";);
+  // Create the V_ILLEGAL node.
----------------
DRop this debug printing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123693/new/

https://reviews.llvm.org/D123693