[PATCH] D128998: [libunwind] Handle G in personality string

[Florian Mayer via Phabricator via llvm-commits]

fmayer added inline comments.


================
Comment at: libunwind/src/DwarfInstructions.hpp:221
+        p &= ~15ULL;
+        for (; p < cfa; p += 16) {
+          __asm__ __volatile__(
----------------
eugenis wrote:
> Is this right? I'd expect to untag from current frame SP to previous frame SP, not to CFA (which could be at arbitrary offset in the frame AFAIK).
> 
ARM64 ABI says this: "The CFA is the value of the stack pointer (sp) at the call site in the previous frame."

(see https://github.com/ARM-software/abi-aa/blob/main/aadwarf64/aadwarf64.rst#42canonical-frame-address)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128998/new/

https://reviews.llvm.org/D128998