[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

Ashay Rane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 12:24:23 PDT 2022


ashay-github created this revision.
ashay-github added reviewers: rriddle, nikic.
Herald added subscribers: bzcheeseman, mgorny.
Herald added a project: All.
ashay-github requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer.
Herald added a project: LLVM.

Prior to this patch, the `add_tablegen()` macro in
llvm/cmake/modules/TableGen.cmake added the install rule only if
`project` matched `LLVM` or `MLIR`.  This patch adds `MLIR_PDLL` to the
list so that the `mlir-pdll` binary is installed.

An alternative to this patch is to make the `mlir-pdll` binary belong to
the `MLIR` project (instead of `MLIR_PDLL`) but doing so requires some
non-trivial changes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131282

Files:
  llvm/cmake/modules/TableGen.cmake


Index: llvm/cmake/modules/TableGen.cmake
===================================================================
--- llvm/cmake/modules/TableGen.cmake
+++ llvm/cmake/modules/TableGen.cmake
@@ -186,7 +186,7 @@
     endif()
   endif()
 
-  if ((${project} STREQUAL LLVM OR ${project} STREQUAL MLIR) AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLVM_BUILD_UTILS)
+  if ((${project} STREQUAL LLVM OR ${project} STREQUAL MLIR OR ${project} STREQUAL MLIR_PDLL) AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLVM_BUILD_UTILS)
     set(export_to_llvmexports)
     if(${target} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
         NOT LLVM_DISTRIBUTION_COMPONENTS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131282.450355.patch
Type: text/x-patch
Size: 637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220805/d1de985a/attachment.bin>


More information about the llvm-commits mailing list