[PATCH] D130516: [llvm] compression classes

Cole Kissane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 12:06:41 PDT 2022


ckissane added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:1474-1475
+      if (!CompressionScheme) {
+        Error("compression class " +
+              (CompressionScheme->Name + " is not available").str());
         return nullptr;
----------------
leonardchan wrote:
> I think this `Error` takes a StringRef, so I think you could have:
> 
> ```
> return Error("compression class " + CompressionScheme->Name + " is not available");
> ```
unfortunately that doesn't work (I tried)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130516/new/

https://reviews.llvm.org/D130516



More information about the llvm-commits mailing list