[PATCH] D131129: [NFC][Inliner] Add Load/Store handler

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 11:05:26 PDT 2022


vitalybuka added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:129
+static cl::opt<int>
+    MemAccessCost("inline-memaccess-cost", cl::Hidden, cl::init(0),
+                  cl::desc("Cost of load/store instruction when inlining"));
----------------
kda wrote:
> An additional cost of zero?  Is that correct?
Yes. So as is it's NFC.
>From my experiments on CTMark ~20 is good for sanitizers. I will try to use this constant internally. It will not be reverted I'll update upstream later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131129/new/

https://reviews.llvm.org/D131129



More information about the llvm-commits mailing list