[PATCH] D131250: [scudo] Try to fix standalone build on armv7
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 5 10:21:59 PDT 2022
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
This looks like a correct fix to me, thank you for looking into it.
================
Comment at: compiler-rt/lib/scudo/standalone/CMakeLists.txt:138-141
set(SCUDO_LINK_LIBS)
+append_list_if(COMPILER_RT_USE_LLVM_UNWINDER ${COMPILER_RT_UNWINDER_LINK_LIBS}
+ SCUDO_LINK_LIBS)
----------------
You should be able to set this unconditionally since `COMPILER_RT_UNWINDER_LINK_LIBS` is already set (or unset) based on the content of `COMPILER_RT_USE_LLVM_UNWINDER` (in the future it might also expand to `-lgcc` on other platforms).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131250/new/
https://reviews.llvm.org/D131250
More information about the llvm-commits
mailing list