[PATCH] D131261: Update llvm.experimental.patchpoint to use opaque pointer for target.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 08:14:47 PDT 2022


nikic added a comment.

> I've also made changes to the tests so that the target operand of patchpoint calls is now a ptr. I've not touched any other pointers in those tests unless strictly necessary (sometimes I had to change other pointers due to the "you can only use ptr in opaque pointers mode" error. It's not clear to me why sometimes it's ok to mix typed and opaque pointers, and other times not...)

Please always update all pointers in the file. It happens to work if the first used pointer type is opaque, but tests really shouldn't mix different pointers...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131261/new/

https://reviews.llvm.org/D131261



More information about the llvm-commits mailing list