[PATCH] D130994: [DAGCombiner] Hoist funnel shifts from logic operation.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 07:48:30 PDT 2022


spatel added a comment.

In D130994#3702138 <https://reviews.llvm.org/D130994#3702138>, @fzhinkin wrote:

> In D130994#3700572 <https://reviews.llvm.org/D130994#3700572>, @spatel wrote:
>
>> Please pre-commit the new tests with baseline results, so we'll just show the diffs in this patch.
>
> Unfortunately, I don't have a permission to commit. Here's a patch adding tests with checks generated using llc build from the main branch: F24025151: D130994_precommit_tests.patch <https://reviews.llvm.org/F24025151>.
>
> I'll appreciate if you can help me with committing it.

Sure: 249a7ed75072 <https://reviews.llvm.org/rG249a7ed750729b79341fb22003a0f4537883d928>

>> Add an alive2 proof link for at least one of the patterns to the patch description, so we can show correctness.
>
> Done, thanks!

Great - please update the patch here Phab with the test changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130994/new/

https://reviews.llvm.org/D130994



More information about the llvm-commits mailing list