[PATCH] D131260: [DAG] select Cond, C, -1 --> or (sext Cond), C if Cond is MVT::i1

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 07:32:59 PDT 2022


deadalnix created this revision.
deadalnix added reviewers: RKSimon, spatel, gchatelet, lei, laytonio.
Herald added subscribers: ecnelises, pengfei, kbarton, hiraditya, nemanjai.
Herald added a project: All.
deadalnix requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This seems to be beneficial overall, except for midpoint-int.ll .

The X86 backend seems to generate zeroing that are not necesary.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131260

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/PowerPC/ppc32-selectcc-i64.ll
  llvm/test/CodeGen/PowerPC/ppc64-P9-setb.ll
  llvm/test/CodeGen/X86/memcmp-more-load-pairs-x32.ll
  llvm/test/CodeGen/X86/memcmp-more-load-pairs.ll
  llvm/test/CodeGen/X86/memcmp-optsize-x32.ll
  llvm/test/CodeGen/X86/memcmp-optsize.ll
  llvm/test/CodeGen/X86/memcmp-pgso-x32.ll
  llvm/test/CodeGen/X86/memcmp-pgso.ll
  llvm/test/CodeGen/X86/memcmp-x32.ll
  llvm/test/CodeGen/X86/memcmp.ll
  llvm/test/CodeGen/X86/midpoint-int.ll
  llvm/test/CodeGen/X86/select.ll
  llvm/test/CodeGen/X86/select_const.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131260.450286.patch
Type: text/x-patch
Size: 62240 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220805/8516d5ea/attachment.bin>


More information about the llvm-commits mailing list