[PATCH] D123693: Transform illegal intrinsics to V_ILLEGAL

Fri Aug 5 07:07:40 PDT 2022

Leonc added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/v_illegal-atomics.ll:40
+; GFX906-OBJ:      s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; GFX906-OBJ-NEXT: v_illegal // 000000000004: FFFFFFFF
+
----------------
arsenm wrote:
> Leonc wrote:
> > arsenm wrote:
> > > This looks backwards. gfx10 is getting the -1 encoding and gfx9 is getting 0
> > Are you sure gfx9 is getting the zero encoding? I thought this line was "address: encoding".
> > If this was wrong wouldn't the tests in `v_illegal-atomics.s` also be wrong?
> You're right, gfx9 looks right. The gfx1030 line with .long 0xffffffff looks wrong.
I'm guessing gfx1030 is due to the disassebler. We know the encoding is correct from the tests in `v_illegal-atomics.s`.
I'll look into it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123693/new/

https://reviews.llvm.org/D123693