[PATCH] D123693: Transform illegal intrinsics to V_ILLEGAL

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/v_illegal-atomics.ll:40
+; GFX906-OBJ:      s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; GFX906-OBJ-NEXT: v_illegal // 000000000004: FFFFFFFF
+
----------------
This looks backwards. gfx10 is getting the -1 encoding and gfx9 is getting 0


================
Comment at: llvm/test/CodeGen/AMDGPU/v_illegal-atomics.ll:53
+; GFX1030-OBJ-NEXT: s_waitcnt_vscnt null, 0x0
+; GFX1030-OBJ-NEXT: .long 0xffffffff
+
----------------
gfx10 has v_illegal, so this should be 0x0 and printed as v_illegal


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123693/new/

https://reviews.llvm.org/D123693