[PATCH] D129599: Apply PGO on SimpleLoopUnswitch

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/PGO-nontrivial-unswitch.ll:5
+; This test checks for a crash.
+; RUN: opt < %s -passes=simple-loop-unswitch -aa-pipeline=
+
----------------
if you are not checking the output, this should probably use `-disable-output`.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/PGO-nontrivial-unswitch.ll:2
+
+; RUN: opt < %s -passes='require<profile-summary>,function(loop-mssa(simple-loop-unswitch<nontrivial>)),print<loops>' \
+; RUN:     --disable-output 2>&1 | sort -b -k 1 | FileCheck %s
----------------
aeubanks wrote:
> aeubanks wrote:
> > I'd just use `llvm/utils/update_test_checks.py` rather than manually checking loops
> > once the test looks good it should be precommitted so we can see the delta this patch gives
> the autogenerated CHECKs aren't in here, it should be
> `; RUN: opt < %s -passes='require<profile-summary>,function(loop-mssa(simple-loop-unswitch<nontrivial>)),print<loops>' -S | FileCheck %`, then delete the existing CHECKs and run `update_test_checks.py`
`,print<loops>'` is this needed? It looks like you are not checking the output (which is emitted to stderr)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129599/new/

https://reviews.llvm.org/D129599