[PATCH] D131248: Address review comments.

Dimitry Andric via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 01:44:39 PDT 2022


dim created this revision.
Herald added a subscriber: mgorny.
Herald added a project: All.
dim requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131248

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -762,8 +762,6 @@
 set(LLVM_PROFDATA_FILE "" CACHE FILEPATH
   "Profiling data file to use when compiling in order to improve runtime performance.")
 
-# Find python before including config-ix, since it needs to be able to search
-# for python modules.
 if(LLVM_INCLUDE_TESTS)
   # Lit test suite requires at least python 3.6
   set(LLVM_MINIMUM_PYTHON_VERSION 3.6)
@@ -772,6 +770,8 @@
   set(LLVM_MINIMUM_PYTHON_VERSION 3.0)
 endif()
 
+# Find python before including config-ix, since it needs to be able to search
+# for python modules.
 find_package(Python3 ${LLVM_MINIMUM_PYTHON_VERSION} REQUIRED
     COMPONENTS Interpreter)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131248.450256.patch
Type: text/x-patch
Size: 777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220805/59f942d6/attachment.bin>


More information about the llvm-commits mailing list