[PATCH] D130431: [BOLT] Ignore functions accessing false positive jump tables

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 23:35:28 PDT 2022


Amir added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:673
       }
-      llvm_unreachable("jump table heuristic failure");
+      AbortedJTs.push_back(JT);
+      continue;
----------------
Sorry, let's not reland this diff.
We want to preserve this `llvm_unreachable` here to crash in cases we failed to recognize the jump table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130431/new/

https://reviews.llvm.org/D130431



More information about the llvm-commits mailing list