[PATCH] D129119: Add llvm::llvm_fast_shutdown()
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 23:31:34 PDT 2022
MaskRay added inline comments.
================
Comment at: lld/Common/ErrorHandler.cpp:102
- // Dealloc/destroy ManagedStatic variables before calling _exit().
- // In an LTO build, allows us to get the output of -time-passes.
- // Ensures that the thread pool for the parallel algorithms is stopped to
- // avoid intermittent crashes on Windows when exiting.
+ // We will call _exit() but want to get the output of -time-passes in an LTO
+ // build. Also ensures that the thread pool for the parallel algorithms is
----------------
MaskRay wrote:
> also mention `-stats`
To be clear, the wording should be in a way that doesn't assume -time-passes as the only exception.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129119/new/
https://reviews.llvm.org/D129119
More information about the llvm-commits
mailing list