[PATCH] D128911: Emit table lookup from TargetLowering::expandCTTZ()

Shubham Narlawar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 22:11:59 PDT 2022


gsocshubham added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:4764
+  SDValue CTTZTableLookup(SDNode *N, SelectionDAG &DAG, SDLoc dl, EVT VT,
+                          SDValue Op, long unsigned NumBitsPerElt) const;
+
----------------
craig.topper wrote:
> No need for `long` here.
> 
> `SDLoc` should be passed by const reference.
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128911/new/

https://reviews.llvm.org/D128911



More information about the llvm-commits mailing list