[PATCH] D131204: llvm-reduce: add a pass for cleaning up branches

[John Regehr via Phabricator via llvm-commits]

regehr added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceBranches.cpp:73
+        if (TBB == BB)
+          BI->setSuccessor(index, NewTarget);
+        ++index;
----------------
arsenm wrote:
> Do you need to call replaceSuccessorsPhiUsesWith or replacePhiUsesWith to avoid breaking those?
let me look into it, thanks.

overall I'm not impressed with the elegance of the code in this function, all suggestions appreciated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131204/new/

https://reviews.llvm.org/D131204