[PATCH] D128470: llvm-reduce: reduce using opt passes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

sorry, forgot to review this the first time around

do we really need this many passes? I'd think that just SROA/InstCombine/SimplifyCFG would be enough



================
Comment at: llvm/test/tools/llvm-reduce/remove-operands-fp.ll:26
 
-; CHECK-LABEL: define void @foo(
+; CHECK-LABEL: define {{(internal )?}}void @foo(
 
----------------
I'd actually prefer not to have `internal` as the canonical reduced output, it's more likely to get thrown away by accident and also increases the amount of text in the output. ditto with tail calls


================
Comment at: llvm/tools/llvm-reduce/DeltaManager.cpp:55
 #define DELTA_PASSES                                                           \
+  DELTA_PASS("using-opt", reduceUsingOptDeltaPass)                             \
   DELTA_PASS("special-globals", reduceSpecialGlobalsDeltaPass)                 \
----------------
we should run this after some of the other passes that remove lots of stuff quickly since this is fairly expensive


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceUsingOpt.h:21
+namespace llvm {
+void reduceUsingOptDeltaPass(TestRunner &Test);
+} // namespace llvm
----------------
this isn't running `opt`, it's just running passes. something like `reduceUsingIRPassesDeltaPass` seems more appropriate


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128470/new/

https://reviews.llvm.org/D128470