[PATCH] D128999: [CGSCC] Don't count calls to intrinsic functions in finding potential deviritualizations.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Other/cgscc-devirt-iteration.ll:104-105
 
 ; The @test3 function checks that when we refine an indirect call to an
 ; intrinsic we still revisit the SCC pass. This also covers cases where the
 ; value handle itself doesn't persist due to the nature of how instcombine
----------------
this comment needs to be updated. I think it makes sense that we don't support this behavior since at this point it's more a phase ordering issue, rather than wanting to rerun the entire pipeline

I also want to change the pipeline to run function-attrs after the function simplification pipeline rather than before it, so this test is a little less relevant


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128999/new/

https://reviews.llvm.org/D128999