[PATCH] D131139: [BOLT] Fix issue related to missing symbol name

[Huan Nguyen via Phabricator via llvm-commits]

nhuhuan added inline comments.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:1050
         registerName(SymbolSize);
-        continue;
+        if (BC->getBinaryFunctions().find(Address) ==
+            BC->getBinaryFunctions().end())
----------------
Amir wrote:
> Can you explain the effect of this condition? Did we skip certain ISyms without this check?
Yes we skipped some symbol names.
If symbol address points to an existing BF, update BF.Symbols
We have that update after, but since it was previously continue, that update is not executed.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131139/new/

https://reviews.llvm.org/D131139