[PATCH] D129599: Apply PGO on SimpleLoopUnswitch

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:3120
+  ProfileSummaryInfo *PSI = nullptr;
+  if(auto OuterProxy = AM.getResult<FunctionAnalysisManagerLoopProxy>(L, AR)
+       .getCachedResult<ModuleAnalysisManagerFunctionProxy>(F))
----------------
still looks like you need to run `git clang-format HEAD~`


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/PGO-nontrivial-unswitch.ll:2
+
+; RUN: opt < %s -passes='require<profile-summary>,function(loop-mssa(simple-loop-unswitch<nontrivial>)),print<loops>' \
+; RUN:     --disable-output 2>&1 | sort -b -k 1 | FileCheck %s
----------------
aeubanks wrote:
> I'd just use `llvm/utils/update_test_checks.py` rather than manually checking loops
> once the test looks good it should be precommitted so we can see the delta this patch gives
the autogenerated CHECKs aren't in here, it should be
`; RUN: opt < %s -passes='require<profile-summary>,function(loop-mssa(simple-loop-unswitch<nontrivial>)),print<loops>' -S | FileCheck %`, then delete the existing CHECKs and run `update_test_checks.py`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129599/new/

https://reviews.llvm.org/D129599