[PATCH] D131197: [TTI] Change new getVectorInstrCost overload to use const reference after D131114
Mingming Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 13:32:15 PDT 2022
mingmingl added a comment.
Thanks for the change! Mostly LGTM.
For my information, any particular reason that a const reference is preferred over a pointer here?
It's true that raw pointers makes ownership unclear, yet they are not uncommon in the codebase. https://llvm.org/docs/ProgrammersManual.html doesn't seem to mention this either.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131197/new/
https://reviews.llvm.org/D131197
More information about the llvm-commits
mailing list