[PATCH] D131191: [CMake] Find python before searching for python modules

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 13:23:13 PDT 2022


compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/CMakeLists.txt:766
+# Find python before including config-ix, since it needs to be able to search
+# for python modules.
+if(LLVM_INCLUDE_TESTS)
----------------
I'd move it to L775 since this is speaking to the `find_package` rather than the setting of the `LLVM_MINIMUM_PYTHON_VERSION`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131191/new/

https://reviews.llvm.org/D131191



More information about the llvm-commits mailing list