[PATCH] D131193: [Docs] Fix duplicate enum item name
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 13:07:52 PDT 2022
MaskRay added a comment.
Since the whole file and the enum is about calling conventions, repeating "Calling convention ..." or "This is a calling convention" is verbose without carrying any weight.
I think they can just be simplified as something like "/// Used for ...". Also, you need to reflow the comments while the first line has been shortened, i.e. run clang-format on the modified lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131193/new/
https://reviews.llvm.org/D131193
More information about the llvm-commits
mailing list