[PATCH] D131115: [Symbolizer] Implement pc element in symbolizing filter.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/MarkupFilter.h:74-83
+  // The semantics of a possible program counter value.
+  enum class PCType {
+    // The semantics are one of the following, determined by the context.
+    DEFAULT = 0,
+    // The address is a return address and must be adjusted to point to the call
+    // itself.
+    RETURN_ADDRESS = 1,
----------------
phosek wrote:
> Nit: it's more common in LLVM to use capitalized names for enums, see https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
I remember looking this up because I wasn't sure, then apparently I promptly forgot about what I found. Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131115/new/

https://reviews.llvm.org/D131115