[PATCH] D122163: [StripDeadDebugInfo] Drop dead CUs

[Alexey Bader via Phabricator via llvm-commits]

bader added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/StripSymbols.cpp:338
-        LiveGVs.insert(DIG);
-
       // Make sure we only visit each global variable only once.
----------------
bader wrote:
> aprantl wrote:
> > This change seems to be unrelated to the above change, and it might be better to discuss it in a separate review. Is this going to drop //all// constant globals?
> I removed this part of the patch, so let discuss it in a separate review.
I moved that change to https://reviews.llvm.org/D131179.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122163/new/

https://reviews.llvm.org/D122163