[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 07:19:09 PDT 2022


fhahn added a comment.

Looks like a nice improvement, thanks!



================
Comment at: llvm/unittests/ADT/SmallVectorTest.cpp:867
-  template <typename T, unsigned N>
-  static unsigned NumBuiltinElts(const SmallVector<T, N>&) { return N; }
 };
----------------
This seems like an unrelated change unless I am missing something? If so, this could likely be pulled out and just submitted separately as NFC


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130268/new/

https://reviews.llvm.org/D130268



More information about the llvm-commits mailing list